Update/sync secrets #48
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btipling
approved these changes
Mar 27, 2025
ggreer
force-pushed
the
update/sync-secrets
branch
from
e8bab66 to
3e5a411
Compare
ggreer
reviewed
Apr 3, 2025
Contributor
ggreer
left a comment
ggreer
left a comment
There was a problem hiding this comment.
I rebased this and fixed conflicts. There are still a bunch of linter errors though.
Makefile
Outdated
| golangci-lint run | ||
|
|
||
| run: | ||
| go run ./cmd/baton-github |
Contributor
There was a problem hiding this comment.
Why add this? People can just run the binary or go run ... right? And then they wouldn't have to deal with annoyances like make failing to pass command line arguments along.
Contributor
Author
|
replacing PR with #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.